Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace `future` with `six` in the python style checker #7374

Merged

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

commented Mar 13, 2019

Problem

The workaround for #7158 was to remove usage of future in the python style checker pex, but documentation was not left behind to defend against re-addition, and so it regressed.

Solution

Switch from future to six, and add a comment.

Result

Checking py3 code from within a py2 pex should work.

@stuhood stuhood requested review from jsirois and cosmicexplorer Mar 13, 2019

@cosmicexplorer
Copy link
Contributor

left a comment

Looking through #7158 was a fun little adventure!

@stuhood stuhood merged commit 38311dc into pantsbuild:master Mar 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/remove-future-dep-from-checker branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.