Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building a pex in release.sh, build it for all supported ABIs. #7393

Merged
merged 2 commits into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

commented Mar 15, 2019

Problem

After #7235, we began building wheels for multiple ABIs and platforms, but when building a pex, we were allowing pex to choose which ABI to use in the output pex, which could result in an unusable output pex: see #7383.

Solution

Explicitly include all ABIs when constructing a pex with -p.

Result

Released and nightly pexes will be larger, but much more compatible. Fixes #7383.

@Eric-Arellano
Copy link
Contributor

left a comment

Thank you Stu for figuring this out!

Will approve after Python 3 is confirmed working.

@@ -569,29 +569,35 @@ function build_pex() {
# If $1 == "fetch", fetches the linux and OSX wheels which were built on travis.
local mode="$1"

local linux_platform="linux_x86_64"
local osx_platform="macosx_10.11_x86_64"
local linux_platform_noabi="linux_x86_64"

This comment has been minimized.

Copy link
@Eric-Arellano

Eric-Arellano Mar 15, 2019

Contributor

Nit

Suggested change
local linux_platform_noabi="linux_x86_64"
local linux_platform_no_abi="linux_x86_64"
local linux_platform="linux_x86_64"
local osx_platform="macosx_10.11_x86_64"
local linux_platform_noabi="linux_x86_64"
local osx_platform_noabi="macosx_10.11_x86_64"

This comment has been minimized.

Copy link
@Eric-Arellano

Eric-Arellano Mar 15, 2019

Contributor

Nit

Suggested change
local osx_platform_noabi="macosx_10.11_x86_64"
local osx_platform_no_abi="macosx_10.11_x86_64"
Show resolved Hide resolved build-support/bin/release.sh

@stuhood stuhood referenced this pull request Mar 15, 2019

Merged

Prepare 1.15.0.dev4 #7394

@stuhood stuhood merged commit 919db8d into pantsbuild:master Mar 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/build-pex-for-all-abis branch Mar 15, 2019

Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request Mar 20, 2019

Fix bad variable name from pantsbuild#7393
platform was no longer defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.