Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Simplify glob matching and directly match in-memory globs as Patterns. #7402
#7299 aligned the behaviour of in-memory (eager) and on-disk (lazy) glob matching, but unfortunately caused a serious performance regression in detection of file owners.
The on-disk (lazy) implementation of glob matching from
In two independently reviewable commits:
... runs at approximately the speed that it did before #7299.
Mar 20, 2019
cosmicexplorer left a comment •
Question about why the test results are different, but this is a fantastic change, it makes glob matching significantly easier to read and extend, and the in-memory glob matching on