Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen constraints for TensorFlow used in example code to work with Python 3.7 #7410

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
2 participants
@OniOni
Copy link
Contributor

commented Mar 20, 2019

Problem

Tensorflow 1.12.0 only has wheels for python version up to 3.6. See: https://pypi.org/project/tensorflow/1.12.0/#files

Solution

Bump minimum version and loosen constraint.

Result

CI lint checks work with python 3.7

@Eric-Arellano Eric-Arellano requested a review from cosmicexplorer Mar 20, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Thank you Mathieu!

Can you please update the PR title to reflect that this only impacts our example code and does not impact any end user of Pants. Maybe something like "Loosen constraints for TensorFlow used in example code to work with Python 3.7"

@OniOni

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@OniOni OniOni changed the title Loosen constraints on tensorflow in preperation of py3.7 Loosen constraints for TensorFlow used in example code to work with Python 3.7 Mar 20, 2019

@Eric-Arellano Eric-Arellano merged commit cbb4fe3 into pantsbuild:master Mar 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.