Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the python version to use in the unstable pex deploy shard. #7411

Merged
merged 1 commit into from Mar 20, 2019

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

commented Mar 20, 2019

Problem

As a follow up to #7401: we need to specify an explicit python version to use in pyenv in order to avoid https://gist.github.com/stuhood/8cfae337c99d2bb21ace0305c2c1d736.

Solution

Specify the pyenv python version.

@stuhood stuhood requested a review from Eric-Arellano Mar 20, 2019

@stuhood stuhood force-pushed the twitter:stuhood/specify-pyenv-py-version branch from b2f630b to 8831353 Mar 20, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Thank you!

@ity

ity approved these changes Mar 20, 2019

@stuhood stuhood merged commit b00403c into pantsbuild:master Mar 20, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@stuhood

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

Merged without waiting for CI in order to fix master.

@stuhood stuhood deleted the twitter:stuhood/specify-pyenv-py-version branch Mar 20, 2019

@stuhood stuhood added this to the 1.15.x milestone Mar 20, 2019

stuhood added a commit that referenced this pull request Mar 21, 2019

Specify the python version to use in the unstable pex deploy shard. (#…
…7411)

### Problem

As a follow up to #7401: we need to specify an explicit python version to use in pyenv in order to avoid https://gist.github.com/stuhood/8cfae337c99d2bb21ace0305c2c1d736.

### Solution

Specify the pyenv python version.

Eric-Arellano added a commit that referenced this pull request Apr 1, 2019

Fix issues with deploy shards not properly setting Python version (#7471
)

There were several problems with the deploy shards introduced by #7401 and not completely cleaned up by #7411:

- Only setting `pyenv global 3.6.3` for the unstable deploy shard, even though the stable one should have this line too.
- Relying on Travis defaulting to the Trusty image. If they were to change this to Xenial, the shards would fail because the Pyenv versions would not match.
- `base_deploy_unstable_multiplatform_pex` extending itself rather than `base_deploy`.

This is also pre-work for getting Python 3.6 on all shards, so that we can use Python 3 in our `build-support` scripts.

stuhood added a commit that referenced this pull request Apr 1, 2019

Fix issues with deploy shards not properly setting Python version (#7471
)

There were several problems with the deploy shards introduced by #7401 and not completely cleaned up by #7411:

- Only setting `pyenv global 3.6.3` for the unstable deploy shard, even though the stable one should have this line too.
- Relying on Travis defaulting to the Trusty image. If they were to change this to Xenial, the shards would fail because the Pyenv versions would not match.
- `base_deploy_unstable_multiplatform_pex` extending itself rather than `base_deploy`.

This is also pre-work for getting Python 3.6 on all shards, so that we can use Python 3 in our `build-support` scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.