Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolve test failing on Python 3.7 due to test using outdated cffi version #7413

Merged

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Mar 21, 2019

Problem

CFFI 1.9.1 does not release a Python 3.7 wheel, so PY=python3.7 ./pants test tests/python/pants_test/backend/python/tasks: -- --verbose -k test_resolve_multiplatform_requirements would fail.

Solution

Simply bump to the most modern CFFI, 1.12.2.

Result

PY=python3.7 ./pants test tests/python/pants_test/backend/python/tasks: -- --verbose -k test_resolve_multiplatform_requirements now passes.

This does not impact end users - only fixes a test.

@Eric-Arellano Eric-Arellano requested review from stuhood and illicitonion Mar 21, 2019

@Eric-Arellano Eric-Arellano merged commit 5d487ef into pantsbuild:master Mar 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:fix-cffi-resolve-py37 branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.