Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for pantsrc-files option #7427

Merged
merged 2 commits into from Mar 25, 2019

Conversation

Projects
None yet
4 participants
@ity
Copy link
Contributor

commented Mar 25, 2019

Problem

Exception in initializing path - failed typecontraint unicode

Solution

string representation for rcfile path - unicode of python 2 is equivalent of str of python 3

Result

no exception raised.

@ity ity changed the title wip - fix for pantsrc-files option fix for pantsrc-files option Mar 25, 2019

@ity ity requested review from blorente and stuhood Mar 25, 2019

@ity

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

@stuhood this needs to be cherrypicked into the 1.15.x branch

@blorente
Copy link
Contributor

left a comment

Thanks!

@stuhood stuhood added this to the 1.15.x milestone Mar 25, 2019

@stuhood stuhood merged commit d62c656 into pantsbuild:master Mar 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stuhood added a commit that referenced this pull request Mar 25, 2019

fix for pantsrc-files option (#7427)
### Problem

Exception in initializing `path` - failed typecontraint unicode

### Solution

string representation for `rcfile` path -  `unicode` of python 2 is equivalent of `str` of python 3 

### Result

no exception raised.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.