Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasattr on Payload #7432

Merged
merged 2 commits into from May 1, 2019

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented Mar 25, 2019

__hasattr__ isn't a thing. hasattr calls getattr and looks for an AttributeError.

See details at https://docs.python.org/3/library/functions.html#hasattr

@illicitonion illicitonion requested review from blorente and Eric-Arellano Mar 25, 2019

@blorente
Copy link
Contributor

left a comment

Cool, thanks!
I'm vary curious as to how you caught this.

@Eric-Arellano
Copy link
Contributor

left a comment

Thanks! Could you please update the PR description to point to https://docs.python.org/3/library/functions.html#hasattr.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/payload-hasattr branch from 56f2a3b to 1e502aa Apr 26, 2019

illicitonion added some commits Mar 25, 2019

Fix hasattr on Payload
__hasattr__ isn't a thing. hasattr calls getattr and looks for an AttributeError.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/payload-hasattr branch from 1e502aa to cc9bbfd Apr 30, 2019

@illicitonion illicitonion merged commit 64a389b into pantsbuild:master May 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/payload-hasattr branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.