Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install guide to use `./pants generate-pants-ini` and `pants_runtime_python_version` #7453

Merged
merged 12 commits into from Apr 13, 2019

Conversation

Projects
None yet
4 participants
@Eric-Arellano
Copy link
Contributor

commented Mar 29, 2019

Now that we support running with Python 3 and have the ./pants generate-pants-ini command, we must update our setup instructions to explain how to use both.

@Eric-Arellano Eric-Arellano changed the title WIP: Update install guide to mention ./pants generate-pants-ini and pants_runtime_python_version Update install guide to mention ./pants generate-pants-ini and pants_runtime_python_version Mar 29, 2019

@stuhood
Copy link
Member

left a comment

Thanks!

Show resolved Hide resolved src/docs/install.md Outdated
Show resolved Hide resolved src/docs/install.md Outdated
Show resolved Hide resolved src/docs/install.md Outdated
@stuhood

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

Mm, the only other consideration is that 1.15.0 will only be picked up once it has been fully released. So this doc edit should not be merged until final has been cut.

@Eric-Arellano Eric-Arellano changed the title Update install guide to mention ./pants generate-pants-ini and pants_runtime_python_version Update install guide to use `./pants generate-pants-ini` and `pants_runtime_python_version` Mar 30, 2019

@Eric-Arellano Eric-Arellano requested a review from blorente Apr 2, 2019

@blorente
Copy link
Contributor

left a comment

Cool! A couple of nitty suggestions, but I love it :) :shipit:

Show resolved Hide resolved src/docs/install.md Outdated
Show resolved Hide resolved src/docs/install.md Outdated
Explain the Options file is a guide on pants.ini
Thanks Borja!

Co-Authored-By: Eric-Arellano <ericarellano@me.com>
Show resolved Hide resolved src/docs/install.md Outdated
Show resolved Hide resolved src/docs/install.md Outdated
@jsirois

jsirois approved these changes Apr 2, 2019

@stuhood

stuhood approved these changes Apr 3, 2019

@Eric-Arellano Eric-Arellano marked this pull request as ready for review Apr 13, 2019

@Eric-Arellano Eric-Arellano merged commit cf5fdcb into pantsbuild:master Apr 13, 2019

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:pants-gen-and-py3-docs branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.