Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
invalidate dependency targets if in combined mode #7455
The doc.scaladoc task (and likely also the doc.javadoc task), when used with --combined is skipping dependencies in the graph during the 'invalidation' stage, because it is not passing invalidate_dependents in the docable predicate that is part of the base class JvmDocGen.
See issue: #7434
In the relevant spot in
This causes the invalidation logic to behave as expected, specifically, invalidating the dependencies within the entire graph for a combined doc build. I tested this locally to ensure the correct behavior, and ran all relevant unit tests.
NOTE: The CI failure listed below seems unrelated to this changeset. The related test within Travis is failing before it even tests the code when attempting to bootstrap Pants. See log here: https://travis-ci.org/pantsbuild/pants/jobs/515087027