Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to twitter.common 0.3.11 to fix DeprecationWarning when using Pants as a PEX #7461

Merged
merged 1 commit into from Mar 30, 2019

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

commented Mar 30, 2019

Problem

0.3.11 was recently released containing one additional Py3 warnings fix: twitter/commons#476

Solution

Pull it in (explicitly, rather than floating to it).

@stuhood stuhood requested review from jsirois and Eric-Arellano Mar 30, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Thanks! If possible, we should cherry-pick this - iirc running the Pex we release includes this DeprecationWarning that's now being fixed.

On that note, could you please update the PR title to Switch to twitter.common 0.3.11 to fix DeprecationWarning when using Pants as a PEX?

@stuhood stuhood changed the title Switch to twitter.common 0.3.11 Switch to twitter.common 0.3.11 to fix DeprecationWarning when using Pants as a PEX Mar 30, 2019

@stuhood stuhood added this to the 1.15.x milestone Mar 30, 2019

@stuhood stuhood merged commit aedf21d into pantsbuild:master Mar 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/twitter-common-0.3.11 branch Mar 30, 2019

stuhood added a commit that referenced this pull request Apr 1, 2019

Switch to twitter.common 0.3.11 to fix DeprecationWarning when using …
…Pants as a PEX (#7461)

### Problem

`0.3.11` was recently released containing one additional Py3 warnings fix: twitter/commons#476

### Solution

Pull it in (explicitly, rather than floating to it).

@stuhood stuhood referenced this pull request Apr 15, 2019

Merged

Upgrade to pex 1.6.6. #7186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.