Join GitHub today
Improve error message for isort failure in IsortRun #7462
Invert the error message to be more readable.
This shouldn't be a console task as things stand. I'm almost positive folks install it as a dependency of / directly in the compile goal for example. Any task not being run directly like that should never be a console task. I know this is vague but hopefully makes sense. If it helps, in v2 the console rule would be fmt, the implementations like isort would be plain rules returning result objects encapsulating the report of what they did. The fmt root console rule would print all the aggregate results it received from isort, gofmt, etc.
Bummer, but good to know.
Is there any way to not swallow stdout and stderr when using
Even if no, hope we can keep this change to make the
Bummer. Once we close out the blacklist and get Py3 on every CI shard, I'll copy my port of
Updated error message to keep the whole command. Think this is still an improvement, albeit much smaller scope than originally intended.