Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo from #7424 to properly fix TensorFlow test during Python 3.7 cron job #7464

Conversation

Projects
None yet
2 participants
@cosmicexplorer
Copy link
Contributor

commented Mar 30, 2019

Problem

#7424 typoed the compiler option sets env var, so didn't actually fix #7417.

Solution

  • Correct the compiler option sets env var name which tells pants to use the new C++ ABI to compile our tensorflow custom operator.

Result

The python 3.7 cron job passes!

cosmicexplorer added some commits Mar 30, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Glad this was a simple fix.

With the cron run, feel free to turn off all irrelevant shards like Py2 and the lint shard. Then, once we confirm Py37 integration tests work, flip this back.

Thanks!

@Eric-Arellano
Copy link
Contributor

left a comment

Yay cron passed! Remember to update PR description to remove the "temporary" part.

Also I recommend rewording the title so it's more clear to end users what's going on. Maybe something like "Fix typo from #7424 to properly fix TensorFlow test during Python 3.7 cron job"

@cosmicexplorer cosmicexplorer changed the title Fix tensorflow compiler option sets env var to use the new C++ ABI in the py37 cron job Fix typo from #7424 to properly fix TensorFlow test during Python 3.7 cron job Mar 30, 2019

@cosmicexplorer

This comment has been minimized.

Copy link
Contributor Author

commented Mar 30, 2019

Done and done!

@cosmicexplorer cosmicexplorer merged commit cb36a09 into pantsbuild:master Mar 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.