Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer pin `pants_runtime_python_version` with `./pants generate-pants-ini` #7469

Merged

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

commented Mar 31, 2019

In pantsbuild/setup#49, we're changing the setup repo's ./pants script to default to Python 3.6, and then fall back to Python 2.7. Thanks to that, we no longer need to use pants_runtime_python_version to get the script to use Python 3.

In fact, we should not set pants_runtime_python_version. The Python version used is an implementation detail we don't want users to have to worry about, and we will be deprecating the option in 1.17.0.dev0. So, us auto-generating the option when it is not even necessary is asking for confusion and a worse experience for users.

@Eric-Arellano Eric-Arellano requested review from stuhood and jsirois Mar 31, 2019

@Eric-Arellano Eric-Arellano added this to the 1.15.x milestone Mar 31, 2019

@jsirois

jsirois approved these changes Apr 1, 2019

@Eric-Arellano Eric-Arellano merged commit 8e433f9 into pantsbuild:master Apr 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:dont-pin-python-version branch Apr 1, 2019

stuhood added a commit that referenced this pull request Apr 1, 2019

No longer pin `pants_runtime_python_version` with `./pants generate-p…
…ants-ini` (#7469)

In pantsbuild/setup#49, we're changing the setup repo's `./pants` script to default to Python 3.6, and then fall back to Python 2.7. Thanks to that, we no longer need to use `pants_runtime_python_version` to get the script to use Python 3.

In fact, we should not set `pants_runtime_python_version`. The Python version used is an implementation detail we don't want users to have to worry about, and we will be deprecating the option in 1.17.0.dev0. So, us auto-generating the option when it is not even necessary is asking for confusion and a worse experience for users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.