Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with deploy shards not properly setting Python version #7471

Merged

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Mar 31, 2019

There were several problems with the deploy shards introduced by #7401 and not completely cleaned up by #7411:

  • Only setting pyenv global 3.6.3 for the unstable deploy shard, even though the stable one should have this line too.
  • Relying on Travis defaulting to the Trusty image. If they were to change this to Xenial, the shards would fail because the Pyenv versions would not match.
  • base_deploy_unstable_multiplatform_pex extending itself rather than base_deploy.

This is also pre-work for getting Python 3.6 on all shards, so that we can use Python 3 in our build-support scripts.

@Eric-Arellano Eric-Arellano requested a review from stuhood Mar 31, 2019

@Eric-Arellano Eric-Arellano added this to the 1.15.x milestone Apr 1, 2019

@stuhood

stuhood approved these changes Apr 1, 2019

@Eric-Arellano Eric-Arellano merged commit 2aa48a2 into pantsbuild:master Apr 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:fix-bad-deploy-shards branch Apr 1, 2019

stuhood added a commit that referenced this pull request Apr 1, 2019

Fix issues with deploy shards not properly setting Python version (#7471
)

There were several problems with the deploy shards introduced by #7401 and not completely cleaned up by #7411:

- Only setting `pyenv global 3.6.3` for the unstable deploy shard, even though the stable one should have this line too.
- Relying on Travis defaulting to the Trusty image. If they were to change this to Xenial, the shards would fail because the Pyenv versions would not match.
- `base_deploy_unstable_multiplatform_pex` extending itself rather than `base_deploy`.

This is also pre-work for getting Python 3.6 on all shards, so that we can use Python 3 in our `build-support` scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.