Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some comments to the example CI script in orgs.md #7478

Merged

Conversation

Projects
None yet
3 participants
@cosmicexplorer
Copy link
Contributor

commented Apr 2, 2019

Problem

https://www.pantsbuild.org/orgs.html#continuous-integration isn't well-documented.

Solution

  • Add some comments to the example CI script.

Result

Users have a good example of how to run a CI script with pants!

@Eric-Arellano
Copy link
Contributor

left a comment

Thank you Danny for updating this!

Will be exciting when we can update this with --query.

@cosmicexplorer cosmicexplorer force-pushed the cosmicexplorer:fix-orgs-example-script branch from 1bcab28 to edb2889 Apr 2, 2019

@cosmicexplorer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Will be exciting when we can update this with --query.

Just added a TODO to #7346 for that, thanks!!

@stuhood
Copy link
Member

left a comment

Unfortunately, the existing pattern is necessary in order to avoid glomming multiple classpaths together. See https://www.pantsbuild.org/3rdparty_jvm.html#managing-transitive-dependencies

@cosmicexplorer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Ah, I had forgotten this even though I knew it well. Then there is a separate issue with background cache activity not stopping before the next pants run in a loop, see https://pantsbuild.slack.com/archives/C046T6T9U/p1553697307236600. I will break out an issue for that, and in the meantime in this PR I will just leave a comment as to why the looping is necessary.

@cosmicexplorer cosmicexplorer changed the title update orgs script to avoid running pants in a loop add some comments to the example CI script in orgs.md Apr 2, 2019

@cosmicexplorer cosmicexplorer force-pushed the cosmicexplorer:fix-orgs-example-script branch from d8ffa0b to 4f95a04 Apr 5, 2019

@cosmicexplorer cosmicexplorer force-pushed the cosmicexplorer:fix-orgs-example-script branch from 4f95a04 to 2f2a42c Apr 5, 2019

@cosmicexplorer cosmicexplorer merged commit b3ef167 into pantsbuild:master Apr 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.