Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cffi (1.11.1 => 1.11.5) #7484

Merged
merged 3 commits into from Apr 4, 2019

Conversation

Projects
None yet
4 participants
@codealchemy
Copy link
Contributor

commented Apr 2, 2019

Problem

Updating a Django project to the latest release (2.2 - released yesterday, using Python 3.6.6) that has pants as a dependency throws an error when calling <project>/manage.py runserver:

$ manage.py runserver
Performing system checks...

AttributeError: cffi library '_constant_time' has no function, constant or global variable named '__spec__'

Solution

Bump to the latest cffi (Full changelog here - it looks like this specific error was addressed in 1.11.3)

馃摑 For context, last update for cffi in pants was in Oct. 2017


鈿狅笍 This initially attempted to bump to the latest version (1.12.2), which ran into segfault issues (as noted below / discussion in Slack) - errors can be seen in the following TravisCI builds:

@Eric-Arellano Eric-Arellano requested a review from illicitonion Apr 2, 2019

@jsirois

jsirois approved these changes Apr 2, 2019

@stuhood

stuhood approved these changes Apr 3, 2019

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

The Python 2.7 unit test shard has failed twice now. Both times seem to be because some of the tests are not running? https://travis-ci.org/pantsbuild/pants/jobs/514900006#L7122

@codealchemy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

The Python 2.7 unit test shard has failed twice now. Both times seem to be because some of the tests are not running? https://travis-ci.org/pantsbuild/pants/jobs/514900006#L7122

Seeing this happen locally as well now, looking more into it (came up 5 times in the linked failed build in CI) - ex. native toolchain test killed by sig 11:

============== test session starts ===============
platform darwin -- Python 2.7.10, pytest-3.6.4, py-1.8.0, pluggy-0.7.1
rootdir: /Users/schmitt/Workspace/pants/.pants.d, inifile: /Users/schmitt/Workspace/pants/.pants.d/test/pytest-prep/CPython-2.7.10/f291bfa84de1083c4d155ddfae5b776bd65e3069/pytest.ini
plugins: timeout-1.2.1, cov-2.4.0
collected 21 items

tests/python/pants_test/backend/native/subsystems/test_libc_resolution.py . [  4%]
..                                         [ 14%]
tests/python/pants_test/backend/native/subsystems/test_native_toolchain.py
FAILURE: Test was killed by signal 11.. [ 19%]

@codealchemy codealchemy force-pushed the codealchemy:bump-cffi branch from 9129516 to ae89b98 Apr 3, 2019

codealchemy added some commits Apr 2, 2019

@codealchemy codealchemy force-pushed the codealchemy:bump-cffi branch from 34d45a5 to d3b879c Apr 4, 2019

@codealchemy codealchemy changed the title Bump cffi to latest release (1.12.2) Bump cffi (1.11.1 => 1.11.5) Apr 4, 2019

@Eric-Arellano Eric-Arellano merged commit 272b0a5 into pantsbuild:master Apr 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@codealchemy codealchemy deleted the codealchemy:bump-cffi branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.