Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pyenv bootstrapping from travis_ci/Dockerfile #7505

Conversation

Projects
None yet
4 participants
@cosmicexplorer
Copy link
Contributor

commented Apr 5, 2019

Problem

The conclusion of #7064 was, after pantsbuild/centos6:latest was updated, to remove the pyenv bootstrapping in travis_ci/Dockerfile as it was now being done in the centos6 base image.

Solution

  • Remove the marked section.

Result

This will speed up all Docker shards that had Py3 installed by 2-3 minutes. So, Linux build engine Py36 and Linux build wheels abi3.

This means overall CI is about 5 minutes faster, and the bootstrap stage 2-3 minutes faster, which is especially significant since that blocks starting other tests.

Finally, this means everywhere we run Pants in CI, we have Python 3 installed now (instead of having to install it again!).

@Eric-Arellano
Copy link
Contributor

left a comment

Woohoo! So much simpler.

@benjyw

benjyw approved these changes Apr 5, 2019

@stuhood

stuhood approved these changes Apr 5, 2019

Copy link
Member

left a comment

Concluding #7064 means we'll drop 2-3 minutes of CI time!

Per centos6 shard, right? Awesome.

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

@stuhood it will speed up all Docker shards that had Py3 installed by 2-3 minutes. So, Linux build engine Py36 and Linux build wheels abi3.

Meaning overall CI is about 5 minutes faster, and bootstrap stage 2-3 minutes faster, which is great because that blocks starting the test.

Also this means everywhere we run Pants in CI, we have Python 3 installed now.

Danny, might want to update PR description to explain this.

@cosmicexplorer cosmicexplorer merged commit 6ec30c2 into pantsbuild:master Apr 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cosmicexplorer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@Eric-Arellano updated with the text from your comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.