Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass interpreter constraint when building the release PEX #7511

Merged

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Apr 5, 2019

Problem

When building the Pex for release, we should be setting interpreter constraints on it to avoid someone trying to run pants.pex36 with Python 2, for example.

This was discovered while Twitter tried upgrading to Python 3.

Solution

Explicitly pass --interpreter-constraint at Pex build-time.

@Eric-Arellano Eric-Arellano requested review from stuhood and jsirois Apr 5, 2019

@Eric-Arellano Eric-Arellano added this to the 1.15.x milestone Apr 5, 2019

@stuhood

stuhood approved these changes Apr 6, 2019

Copy link
Member

left a comment

Thanks!

@stuhood

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

This one was well-discussed, so going to go ahead and merge. Thank you!

@stuhood stuhood merged commit 56a3322 into pantsbuild:master Apr 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stuhood added a commit that referenced this pull request Apr 6, 2019

Pass interpreter constraints to the Pex we release (#7511)
### Problem
When building the Pex for release, we should be setting interpreter constraints on it to avoid someone trying to run `pants.pex36` with Python 2, for example.

This was discovered while Twitter tried upgrading to Python 3.

### Solution
Explicitly pass `--interpreter-constraint` at Pex build-time.

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:pex-interpreter-constraint branch Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.