Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend pantsd test timeout #7527

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented Apr 10, 2019

This is how long it takes for tests to pass on my laptop

@illicitonion illicitonion requested a review from cosmicexplorer Apr 10, 2019

@stuhood

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Inexplicable flakiness (unless that value was magical somehow?) Have rebased and pushed.

@@ -47,7 +47,7 @@ def assert_started(self, timeout=16):
self._check_pantsd_is_alive()
return self._pid

def assert_pantsd_runner_started(self, client_pid, timeout=4):
def assert_pantsd_runner_started(self, client_pid, timeout=12):

This comment has been minimized.

Copy link
@cosmicexplorer

cosmicexplorer Apr 12, 2019

Contributor

I also notice these kinds of timeouts being required locally, the pantsd integration tests would consistently fail whenever I ran them. So this increase seems to make sense.

@@ -521,7 +521,6 @@ def test_pantsd_sigint(self):
signal.SIGINT,
regexps=["""\
\\[INFO\\] Sending SIGINT to pantsd-runner with pid [0-9]+, waiting up to 5\\.0 seconds before sending SIGKILL\\.\\.\\.
Interrupted by user.
Interrupted by user:
Interrupted by user over pailgun client!

This comment has been minimized.

Copy link
@cosmicexplorer

cosmicexplorer Apr 12, 2019

Contributor

Having all these very similar messages in a row looks pretty silly, but I didn't spend time to fix it up in #6574. Sorry!

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/pantsd-test-startup-timeout branch from 52d8b67 to f5a25a5 Apr 26, 2019

Extend pantsd test timeout
This is how long it takes for tests to pass on my laptop

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/pantsd-test-startup-timeout branch from f5a25a5 to 1f70ca8 Apr 29, 2019

@illicitonion illicitonion merged commit 5a3239f into pantsbuild:master Apr 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/pantsd-test-startup-timeout branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.