Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve `--pantsd-invalidation-globs` using fingerprint #7531

Merged
merged 10 commits into from Apr 16, 2019

Conversation

Projects
None yet
4 participants
@patliu85
Copy link
Contributor

commented Apr 10, 2019

It's a continuation of #7454

Problem

Improve --pantsd-invalidation-globs implementation with actual fingerprinting. See #5567 for details

Solution

Compute and save initial Snapshots keyed by globs. Re-compute Snapshots for every fs event and compare with originals.

@stuhood stuhood requested review from stuhood, ity and blorente Apr 11, 2019

@stuhood
Copy link
Member

left a comment

Thanks!

@ity
Copy link
Contributor

left a comment

thank you!

Show resolved Hide resolved src/python/pants/pantsd/service/scheduler_service.py Outdated
Show resolved Hide resolved src/python/pants/pantsd/service/scheduler_service.py Outdated
@blorente
Copy link
Contributor

left a comment

This looks great, just a couple of nits :)

@blorente
Copy link
Contributor

left a comment

Thank you for the changes, this looks great!

pliu

@stuhood stuhood merged commit 0aba567 into pantsbuild:master Apr 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:pliu/5567 branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.