Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestPantsDaemonIntegration.test_signal_pailgun_stream_timeout flakiness #7533

Conversation

Projects
None yet
3 participants
@cosmicexplorer
Copy link
Contributor

commented Apr 11, 2019

Problem

TestPantsDaemonIntegration.test_signal_pailgun_stream_timeout is flaky: see https://travis-ci.org/pantsbuild/pants/jobs/518580593. 0.01 seconds is obviously a pretty long time to wait for a computer, so waiting that long after sending a signal to a subprocess means the subprocess might have exited during that time.

Solution

  • Decrease the timeout for that test to a much smaller number.

Result

TestPantsDaemonIntegration.test_signal_pailgun_stream_timeout is hopefully less flaky!

cosmicexplorer added some commits Apr 11, 2019

@cosmicexplorer cosmicexplorer force-pushed the cosmicexplorer:decrease-pailgun-stream-timeout-for-testing branch from 8035b34 to a1ca1b8 Apr 11, 2019

@cosmicexplorer cosmicexplorer merged commit 1b6a438 into pantsbuild:master Apr 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@blorente
Copy link
Contributor

left a comment

I know I'm late to the party, but thanks! This has definitely been a sore test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.