Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go test flags bug and add integration test #7539

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@cosmicexplorer
Copy link
Contributor

commented Apr 12, 2019

Problem

#7326 added back the ability to go test transitive deps, but also failed to test adding any options (including the new --shlexed-build-and-test-flags) to the command line, which ends up raising an exception.

Solution

  • Correctly flatten --shlexed-build-and-test-flags when creating the go test command line.
  • Add an integration test with the use of options to avoid regressions.

Result

Go testing doesn't fail when provided extra flags!

@cosmicexplorer cosmicexplorer requested review from stuhood, benjyw and ity Apr 12, 2019

@cosmicexplorer cosmicexplorer force-pushed the cosmicexplorer:fix-go-test-flags branch from 7b70041 to b52cef2 Apr 12, 2019

@stuhood
Copy link
Member

left a comment

Thanks.

@ity

ity approved these changes Apr 12, 2019

@cosmicexplorer cosmicexplorer merged commit 152d632 into pantsbuild:master Apr 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.