Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add the CI skipping label to amended commits. #7545

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Projects
None yet
2 participants
@benjyw
Copy link
Contributor

commented Apr 12, 2019

For two reasons:

  1. The git status command we use to detect the files about to be added won't see any files that weren't amended, and may reach the wrong conclusion.

  2. Even if we fix 1), the user may have concluded that they want to delete that label and force a CI anyway, for whatever reason, and we don't want to keep overriding that.

@benjyw benjyw requested review from stuhood and illicitonion Apr 12, 2019

@benjyw benjyw merged commit 75b327b into pantsbuild:master Apr 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:fix_prepare_commit_msg_hook branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.