Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-needed `travis-ci.sh` ci wrapper. #7548

Merged
merged 3 commits into from Apr 14, 2019

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

commented Apr 13, 2019

This guarded Pants from seeing bad pyenv shims, but Pants interpreter
selection has since been made robust to bad interpreters in 874ce34.

That said, an overly-specific interpreter cache test is loosened to
account for path differences between pyenv shim scripts and underlying
re-directed python interpreter binary paths.

@jsirois

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2019

Prep for / broken off from #7186.

@Eric-Arellano
Copy link
Contributor

left a comment

Yay simplicity! Think we need to add that env var, then will approve.

@benjyw

benjyw approved these changes Apr 14, 2019

jsirois added some commits Apr 13, 2019

Remove un-needed `travis-ci.sh` ci wrapper.
This guarded Pants from seeing bad pyenv shims, but Pants interpreter
selection has since been made robust to bad interpreters in 874ce34.
Loosen overly-specific test.
We only care that the identity (major/minor constraint really) of the
current interpreter is found in the cache filter tests; we don't care
about the underlying path to the interpreter, which can be muddied by
pyenv shims.

@jsirois jsirois force-pushed the jsirois:issues/6927-prep/kill-travis-ci.sh branch from eefab90 to 6b0bb60 Apr 14, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Great find with the $TRAVIS env var. Thanks!

jsirois added a commit to jsirois/pants that referenced this pull request Apr 14, 2019

@jsirois jsirois merged commit ef7f664 into pantsbuild:master Apr 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6927-prep/kill-travis-ci.sh branch Apr 14, 2019

jsirois added a commit that referenced this pull request Apr 14, 2019

blorente added a commit that referenced this pull request Apr 17, 2019

Use ci.sh instead of travis-ci.sh (#7582)
**Problem**

`travis-ci.sh` was removed in ef7f664 (#7548), but the changes to the cron shard in  #7440  were not rebased to reflect this update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.