Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abi3 pex check to allow abi3 wheels. #7549

Merged

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

commented Apr 13, 2019

Even though the pex Pants uses doesn't currently resolve abi3 wheels,
newer pex does and our check should support multiple wheel abis to
support abi3 pexes going forward.

Fix abi3 pex check to allow abi3 wheels.
Even though the pex Pants uses doesn't currently resolve abi3 wheels,
newer pex does and our check should support multiple wheel abis to
support abi3 pexes going forward.
@jsirois

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2019

Prep for / broken off from #7186.

@jsirois jsirois requested a review from Eric-Arellano Apr 14, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Great. Thank you John for this and for breaking it out from the Pex upgrade PR!

@jsirois jsirois merged commit a3cb9c0 into pantsbuild:master Apr 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6927-prep/abi-check-allow-abi3 branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.