Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce argv for JavacCompile to text_type. #7560

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

commented Apr 14, 2019

This was a straggler from #7529.

Fixes #7559

@jsirois

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2019

Locally reproed the cron CI failure and this fix with:

PY=python2.7 ./pants test.pytest --cache-ignore tests/python/pants_test/backend/jvm/tasks/jvm_compile/javac: -- -vsk JavacCompileIntegration

@jsirois jsirois requested review from cosmicexplorer and Eric-Arellano Apr 14, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Thank you.

@jsirois jsirois referenced this pull request Apr 14, 2019

Open

Fix issues found during Python 3 port #6071

1 of 5 tasks complete
@cosmicexplorer
Copy link
Contributor

left a comment

Thank you!

Coerce argv for JavacCompile to text_type.
This was a straggler from #7529.

Fixes #7559

@jsirois jsirois force-pushed the jsirois:issues/7559 branch from a34d1fd to e7845b5 Apr 14, 2019

@jsirois jsirois merged commit 09d368b into pantsbuild:master Apr 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/7559 branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.