Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory materialization is visible to others. #7562

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

commented Apr 15, 2019

Previously when the store materialized directories it would not fsync.
This led to the possibility that processes spawned against chroots
materialized by the store would see only partial files.

Fixes #7450

Directory materialization is visible to others.
Previously when the store materialized directories it would not fsync.
This led to the possibility that processes spawned against chroots
materialized by the store would see only partial files.

Fixes #6450

@jsirois jsirois requested review from illicitonion and stuhood Apr 15, 2019

@jsirois

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2019

I went from 1/2 to 1/5 failure rate in to 0 failures in 1+ hour running ./pants test.pytest --cache-ignore tests/python/pants_test/rules:test_integration -- -vsk test_mixed_python_tests in a loop.

@cosmicexplorer
Copy link
Contributor

left a comment

This is an incredible fix!

@cosmicexplorer

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

I went from 1/2 to 1/5 failure rate in to 0 failures in 1+ hour running ./pants test.pytest --cache-ignore tests/python/pants_test/rules:test_integration -- -vsk test_mixed_python_tests in a loop.

This could be the subject of a blog post!! I can look into writing that.

@illicitonion
Copy link
Contributor

left a comment

Good catch :) Thanks!

@jsirois jsirois merged commit 370e650 into pantsbuild:master Apr 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/7450 branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.