protobuf gen triggers less often #7565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Apr 16, 2019
| } | ||
| // 1026 |
There was a problem hiding this comment.
Is this trailing comment necessary?
There was a problem hiding this comment.
Oops, leftover from when I was testing when things trigger :)
Currently it triggers every rust build, which slows things down a lot. Instead, only trigger if generated code actually changes.
blorente
approved these changes
Apr 16, 2019
| let mut rustfmt_config = PathBuf::from(env!("CARGO_MANIFEST_DIR")); | ||
| rustfmt_config.pop(); // bazel_protos | ||
| rustfmt_config.pop(); // process_execution | ||
| rustfmt_config.push("rustfmt.toml"); |
There was a problem hiding this comment.
It's unfortunate that we don't have a good way of not depending on this dir structure, something like CARGO_WORKSPACE_DIR. However, would it make sense for this to fail with a nice error here? Something like panic!("I assumed that rustfmt.toml was two levels up from {}, but the directory structure seems to have changed", env!("CARGO_MANIFEST_DIR")).
Maybe not worth the effort since it will error anyway, I just don't like having to figure out the implicit dependency when it changes.
On travis, it may be across devices
illicitonion
force-pushed
the
dwagnerhall/protogen/idempotent
branch
from
c2a499e
to
a7c295e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it triggers every rust build, which slows things down a lot.
Instead, only trigger if generated code actually changes.