Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty failed target to ensure pants raises the error if python test fails #7570

Merged
merged 2 commits into from Apr 22, 2019

Conversation

Projects
None yet
2 participants
@patliu85
Copy link
Contributor

commented Apr 15, 2019

Problem

Users run a command like:

./pants test some_dir_path/src/test/python/app_dir:test

The pants command succeeded even though python test failed.

The root cause was the test target not recorded in <junitxml> file so when failure/error was detected, pants couldn't get the failed test target from <junitxml> file.

Solution

If test failure/error is detected but pants can't get the failed test target from <junitxml> file, then pick the first test target as the failed test target.

@patliu85 patliu85 force-pushed the twitter:fix-test-failed-target-null-issue branch from 4c8c375 to 6bd1e7a Apr 16, 2019

@patliu85 patliu85 force-pushed the twitter:fix-test-failed-target-null-issue branch from cab54e2 to c7a87bf Apr 17, 2019

@stuhood stuhood merged commit c6c9163 into pantsbuild:master Apr 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:fix-test-failed-target-null-issue branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.