Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify precedence logic for options which may be overridden on targets #7594

Merged
merged 6 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@cosmicexplorer
Copy link
Contributor

commented Apr 19, 2019

Problem

Addresses the first item of #7183. MirroredTargetOptionMixin was created in backend/native/ to make it easier to support pants options with equivalents on a target payload entry, for example. This generalizes that and uses it to simplify some options in tasks in the jvm backend.

Solution

commits are independently reviewable

  • move MirroredTargetOptionMixin to build_graph/ and substantially refactor it.
  • make ZincLanguageMixin a MirroredTargetOptionMixin (this allows some of the DependencyContext logic to be simplified).
  • remove the --default-workflow option from RscCompile, renaming it to --workflow and using the shared logic from MirroredTargetOptionMixin.

Result

The path to create options which can be overridden by targets and to access them from a task is more clear. The RscCompile task now uses the shared option precedence logic of MirroredTargetOptionMixin instead of reinventing it.

cosmicexplorer added some commits Apr 19, 2019

@cosmicexplorer cosmicexplorer requested review from stuhood and illicitonion Apr 19, 2019

@cosmicexplorer cosmicexplorer force-pushed the cosmicexplorer:fix-rsc-tagging branch from cc55159 to ace8efa Apr 19, 2019

@cosmicexplorer cosmicexplorer requested a review from stuhood Apr 25, 2019

@cosmicexplorer cosmicexplorer merged commit 4395289 into pantsbuild:master Apr 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.