Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix #7591 breaking OSX Rust tests shard due to Pyenv global issue #7602

Merged
merged 2 commits into from Apr 22, 2019

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Apr 22, 2019

In #7591, we decided that (in general) we should avoid pyenv global and ~/.pyenv/shims to instead favor the more explicit ~/.pyenv/versions/{py_version}/bin.

Because of Travis caching, we did not catch that this change would break the OSX Rust shard, until merging the PR into master. https://travis-ci.org/pantsbuild/pants/jobs/522771730#L216

Here, we teach the OSX Rust shard to point to the versions folder. We also install Python 2.7 through Pyenv for consistency with the other OSX shards, as system Python has an outdated OpenSSL.

@Eric-Arellano Eric-Arellano requested review from stuhood and jsirois Apr 22, 2019

@jsirois
Copy link
Member

left a comment

Thanks for picking this up.

Show resolved Hide resolved build-support/travis/travis.yml.mustache Outdated
Fix typo
Thank you John!

@Eric-Arellano Eric-Arellano merged commit 216440d into pantsbuild:master Apr 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:hotfix-osx-rust-shard branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.