Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor uses of dirutil.py to use the new default Unicode semantics #7604
Now that we finished the switchover in #7603 so that the dirutil functions default to Unicode, we can drop explicit arguments for simpler code.
The main motivations for using this default are:
jsirois left a comment
I am not a fan of this, but as you say - it does mirror open defaults. I think the original sin was
I won't block.
Likely true, although worth pointing out that this is less of an issue in Python 3 than Python 2. Python 3 fails eagerly when mixing unicode and bytes, so it's far less likely developers will write code that messes up unicode vs. bytes. This contrasts with Py2 that freely mixes the two.
The main motivations I see for this are:
Still, acknowledged. Thanks for the review!