Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test symlink is always seen by engine. #7605

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

commented Apr 22, 2019

Previously the link was created without invalidating the destination
path which could lead to rare spurious errors finding the target. Now
a test helper is used to create the symlink which handles invalidation.

Fixes #7250

Ensure test symlink is always seen by engine.
Previously the link was created without invalidating the destination
path which could lead to rare spurious errors finding the target.

Fixes #7250

@jsirois jsirois requested a review from stuhood Apr 22, 2019

@stuhood
Copy link
Member

left a comment

Thank you John!

@jsirois

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

@stuhood please turn on your bs-detector. I was not able to convince myself by reading code that this is relevant / a real fix.

@stuhood

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

@stuhood please turn on your bs-detector. I was not able to convince myself by reading code that this is relevant / a real fix.

My BS detector is not detecting anything: it's definitely the case that the engine should need manual invalidation here.

The only suspicious thing is why this would ever succeed without that invalidation, since it should not be racing anything. But the call on the previous line should be triggering invalidation of the parent directory. There should be log output during the test about which files are being invalidated, which would be worth examining.

@jsirois jsirois merged commit 916080c into pantsbuild:master Apr 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/7250 branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.