Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cron job by wrapping the python binary in text_type() in v2 pytest #7611

Conversation

Projects
None yet
2 participants
@cosmicexplorer
Copy link
Contributor

commented Apr 23, 2019

Problem

The cron job is failing due to a type check error in an ExecuteProcessRequest creation: see https://travis-ci.org/pantsbuild/pants/jobs/522402485.

Solution

  • Wrap sys.executable in text_type() not str().
    • This is necessary after the changes in #7529.

Result

The cron job passes! This fix can be verified by running ./pants2 --print-exception-stacktrace --v2 --no-v1 test testprojects/tests/python/pants/dummies:target_with_source_dep and seeing that it passes.

@Eric-Arellano
Copy link
Contributor

left a comment

Thanks Danny.

@cosmicexplorer cosmicexplorer force-pushed the cosmicexplorer:fix-cron-job-type-failure-python-binary branch from 54215a0 to 541cce9 Apr 24, 2019

@cosmicexplorer cosmicexplorer merged commit 7e19fa9 into pantsbuild:master Apr 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.