Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download rustup-init without --proto to work around outdated centos6 curl version #7615

Conversation

Projects
None yet
2 participants
@cosmicexplorer
Copy link
Contributor

commented Apr 23, 2019

Problem

Our CI is broken right now, failing to build pants.pex in our Linux shards running CentOS6, e.g. https://travis-ci.org/pantsbuild/pants/jobs/523606246. This appears to be an instance of an upstream rustup development, noted by @Eric-Arellano in rust-lang/rustup.rs#1794 (comment). While there may be a solution which maintains the security that the rustup folks desire, this diff should work around the issue for now.

Solution

Result

CI should pass!

@cosmicexplorer cosmicexplorer changed the title download rustup-init without --proto download rustup-init without --proto to work around outdated centos6 curl version Apr 23, 2019

@cosmicexplorer cosmicexplorer force-pushed the cosmicexplorer:fix-rustup-curl-proto-arg-error-centos6 branch from 9f079f6 to 0e44bc0 Apr 23, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Note that Travis will test the case where we don't need the downgrade thanks to the OSX shards, which do have a modern enough version of Curl to allow --proto. So, both cases are tested.

Thank you for fixing this, Danny!

@cosmicexplorer cosmicexplorer requested review from jsirois and illicitonion Apr 23, 2019

@cosmicexplorer cosmicexplorer merged commit 7ba2e9c into pantsbuild:master Apr 24, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

cosmicexplorer added a commit that referenced this pull request Apr 28, 2019

use upstream rustup init script download workaround for old curl vers…
…ion on CentOS6 (#7619)

### Problem

See #7615, where we had to work around a sudden error downloading rustup on our CentOS6 docker image bootstrap shards. A workaround was made available from rustup via rust-lang/rustup.rs#1803, so we can remove our own workaround.

### Solution

- Remove platform-specific logic from `bootstrap_rust.sh`.
- Remove the need to output the `rustup-init` script to a temporary file.

### Result

Our bootstrap shards should continue working!

cosmicexplorer referenced this pull request Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.