Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use upstream rustup init script download workaround for old curl version on CentOS6 #7619

Merged
merged 4 commits into from Apr 28, 2019

Conversation

Projects
None yet
2 participants
@cosmicexplorer
Copy link
Contributor

commented Apr 24, 2019

Problem

See #7615, where we had to work around a sudden error downloading rustup on our CentOS6 docker image bootstrap shards. A workaround was made available from rustup via rust-lang/rustup.rs#1803, so we can remove our own workaround.

Solution

  • Remove platform-specific logic from bootstrap_rust.sh.
  • Remove the need to output the rustup-init script to a temporary file.

Result

Our bootstrap shards should continue working!

@cosmicexplorer cosmicexplorer force-pushed the cosmicexplorer:try-rustup-init-fix branch from 8c74219 to 6e5b819 Apr 24, 2019

cosmicexplorer added some commits Apr 25, 2019

@cosmicexplorer cosmicexplorer changed the title [WIP] test rustup init script fix use upstream rustup init script download workaround for old curl version on CentOS6 Apr 27, 2019

@cosmicexplorer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

This is now ready for review!

@Eric-Arellano
Copy link
Contributor

left a comment

Yay! Thank you for following up on this.

@cosmicexplorer cosmicexplorer merged commit a6f96ca into pantsbuild:master Apr 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.