Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor and modernize `check_header.py` to use Python 3 #7635
Makes the following improvements:
Totally forgot that's a thing.
I'd love to see it happen. I unfortunately don't think I'll be able to be the one to do it. I start work with Twitter tomorrow and I'll consequently have less time for "fun" refactors like this / will be much more focused in what my PRs involve.
Ftr, my main motivation here is that we soon will need to allow the header to be either Py2 style (current) or Py3 style (no
Bump on this thread.
1.17.0.dev0 is now upon us, so we can very soon start removing Py2. Before doing that, we need to update
Unless someone has time to instead use #7515, or Twitter would like me to spend time on that approach over V2 work, I encourage us to use this PR for now.