Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Two targets can swap positions with pantsd (again) #7642
Re-landing #7617 without slowing down the happy path of no cycles.
Before this PR, nothing would remove the edges of a dirty node, so if
With this PR, if we detect a cycle, but detect that there may be dirty
This is specifically in place to handle the cycle scenario - the dirty
There's an ugliness here that we still don't remove obsolete edges, so
There's probably a slightly more principled solution here along the
This re-landing optimises for the no cycle case, which is very strongly expected to be the common case in Pants, as cycles represent errors.