Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for reference cycle from Target to BuildGraph #7666

Merged
merged 2 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@patliu85
Copy link
Contributor

commented May 6, 2019

Problem

As described in #5668

Solution

Use weakref to remove the BuildGraph reference from Target.

@stuhood

stuhood approved these changes May 6, 2019

Copy link
Member

left a comment

Thanks!

@stuhood

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@patricklaw : It looks like the OSX bootstrap shards got restarted at a bad point, so all of the OSX shards have failed: you should be able to ignore those.

But there are some actual errors on the contrib shards: https://travis-ci.org/pantsbuild/pants/jobs/529019651 ... it looks like it's because there are tests that do a bad job of mocking the BuildGraph.

@patliu85 patliu85 force-pushed the twitter:pliu/5668 branch from 7da3e9a to a10e82b May 7, 2019

@stuhood stuhood merged commit ba0132d into pantsbuild:master May 7, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@stuhood stuhood deleted the twitter:pliu/5668 branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.