Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor v2 TestResult model to use enum #7677

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented May 8, 2019

Now that we have an implementation for enums, we should not be using this pseudo-enum implementation because it makes the engine type checking less stringent than desired. That is, before any text_type would work for Status, whereas now only accepted enum values work.

@Eric-Arellano Eric-Arellano requested a review from cosmicexplorer May 8, 2019

@stuhood

stuhood approved these changes May 8, 2019

@Eric-Arellano Eric-Arellano merged commit 3742edb into pantsbuild:master May 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:v2-test-enum branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.