Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix 'current' platform check for python_dist() targets with C/C++ sources #7687
Currently, in BuildLocalPythonDistributions, any
This wasn't noticed until #7618, which ended up essentially assigning
The platform checking in ResolveRequirementsTaskBase is removed entirely, only occurring during python binary creation instead. When that platform checking does occur,
illicitonion left a comment
The first half looks reasonable. I'm not sold on the flag. It feels like we should either:
It feels like the flag is trying to do both, but I'm not sure why we want to make it configurable?
2 times, most recently
May 10, 2019
Ok, I've implemented:
This approach also fixes the failure we were seeing in another repo using pants.
I've just pushed a change which replaces some of the more complex changes in
This means the
This test could probably be created by creating a new class in
Going to be handing this off to @illicitonion, whom I thank immensely for diving into this.