Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ResettablePool #7688

Merged
merged 5 commits into from May 9, 2019

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented May 9, 2019

We now just use the tokio runtime for all async work.

Commits are separately reviewable.

@illicitonion illicitonion requested review from stuhood and blorente May 9, 2019

@blorente
Copy link
Contributor

left a comment

This is really cool! Thanks.

Always +1 for making each commit reviewable independently, is so much easier to learn that way.

store
.store_bytes(EntryType::File, bytes, false)
.wait()
.expect("Storing file bytes")

This comment has been minimized.

Copy link
@blorente

blorente May 9, 2019

Contributor

Why the change in the error string from something negative to something positive?

This comment has been minimized.

Copy link
@illicitonion

illicitonion May 9, 2019

Author Contributor

I never know which to prefer in this context. Switched back :)

})
.then(|blocking_result| match blocking_result {
Ok(v) => v,
Err(blocking_err) => panic!("TODO: {}", blocking_err),

This comment has been minimized.

Copy link
@blorente

blorente May 9, 2019

Contributor

TODO

This comment has been minimized.

Copy link
@illicitonion

illicitonion May 9, 2019

Author Contributor

Oops! Done. There's not an obviously good thing to do here; we could either directly panic, or return a String error... Switched to return an error.

@stuhood

stuhood approved these changes May 9, 2019

Copy link
Member

left a comment

Thanks!

@illicitonion illicitonion merged commit 1ad981f into pantsbuild:master May 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/async-fs branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.