Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency cycle with cache folder #7693

Merged

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented May 9, 2019

Problem

There were two issues causing an import of subsystem_util.global_subsystem_instance() to fail:

  1. engine/goal.py did not properly declare its dependency on cache
  2. cache/ had a declared dependency on engine:native, even though it was never used.

Solution

Update both engine/goal.py's and cache/'s BUILD to reflect all the actual dependencies used, as several were missing and several unused.

Result

The offending import now works properly.

Eric-Arellano added some commits May 9, 2019

Convert cache BUILD into an entry for each file
This pattern allows us to only import the code we actually care about and makes it easier to ensure requirements actually match whats used.
Revert "Convert cache BUILD into an entry for each file"
This reverts commit ec9077d.

Actually this API becomes really annoying to import.

@Eric-Arellano Eric-Arellano requested review from stuhood and cosmicexplorer May 9, 2019

@stuhood

stuhood approved these changes May 9, 2019

Copy link
Member

left a comment

Thanks!

@Eric-Arellano Eric-Arellano merged commit 6c54478 into pantsbuild:master May 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:fix-cache-engine-dep-cycle branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.