Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shellcheck.py and apply first round of fixes #7698

Merged
merged 19 commits into from May 14, 2019
Merged

Add shellcheck.py and apply first round of fixes #7698

merged 19 commits into from May 14, 2019

Commits on May 10, 2019

  1. Fix issues with common.sh

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    8665838 View commit details
    Browse the repository at this point in the history

  2. Fix some issues with bin/native

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    d11457c View commit details
    Browse the repository at this point in the history

  3. mostly fix pants_venv and virtualenv

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    81ea6d2 View commit details
    Browse the repository at this point in the history

  4. fix python/clean.sh

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    18fda90 View commit details
    Browse the repository at this point in the history

  5. mostly fix the check_x scripts

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    6bea780 View commit details
    Browse the repository at this point in the history

  6. fix isort.sh

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    1ab916f View commit details
    Browse the repository at this point in the history

  7. improve more bin scripts

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    0a9af30 View commit details
    Browse the repository at this point in the history

  8. fix issues with ci.sh

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    98398c2 View commit details
    Browse the repository at this point in the history

  9. fix issues with install_git_hooks

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    5bed7e9 View commit details
    Browse the repository at this point in the history

  10. fix multiple issues with release.sh

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    8222197 View commit details
    Browse the repository at this point in the history

  11. Add shellcheck.py script

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    d088668 View commit details
    Browse the repository at this point in the history

  12. Apply more fixes

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    6ac56f0 View commit details
    Browse the repository at this point in the history

  13. tweaks before review

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    ad919f9 View commit details
    Browse the repository at this point in the history

  14. Fix ci.sh bug by using array instead of string

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    10121b1 View commit details
    Browse the repository at this point in the history

  15. Don't quote glob

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    aafb1bd View commit details
    Browse the repository at this point in the history

  16. Fix issues with arrays vs strings in release.sh

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    9bba238 View commit details
    Browse the repository at this point in the history

  17. Fix issue with build-support/bin/check_banned_imports.sh

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    579284d View commit details
    Browse the repository at this point in the history

  18. Explain # shellcheck source=/dev/null

    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    308a0ff View commit details
    Browse the repository at this point in the history

  19. Revert all changes to check_banned_imports.sh 

    I can't get the array working.
    @Eric-Arellano
    Eric-Arellano committed May 10, 2019
    Copy the full SHA
    4e96fc3 View commit details
    Browse the repository at this point in the history