Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor check_banned_imports.py to allow Python 3 files to import subprocess #7706

Merged
merged 3 commits into from May 13, 2019
Merged

Refactor check_banned_imports.py to allow Python 3 files to import subprocess #7706

merged 3 commits into from May 13, 2019

Commits on May 11, 2019

  1. Approach #1: check_banned_import_if_snippet_present()

    @Eric-Arellano
    Eric-Arellano committed May 11, 2019
    Copy the full SHA
    d6d2a90 View commit details
    Browse the repository at this point in the history

  2. Approach #2: DRY filter_files()

    @Eric-Arellano
    Eric-Arellano committed May 11, 2019
    Copy the full SHA
    d0a5047 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2019

  1. Review feedback

    @Eric-Arellano
    Eric-Arellano committed May 13, 2019
    Copy the full SHA
    13bb1b4 View commit details
    Browse the repository at this point in the history