Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support in `check_header.py` for Python 3-style headers #7713

Merged
merged 4 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented May 13, 2019

Problem

Once we drop Python 2, we can simplify our headers to no longer use from __future__ import and # coding=utf-8, as both are repetitive and add unnecessary code.

Still, we (at least temporarily) want to support the Python 2 style as well.

Solution

Allow check_header.py to accept either style.

Show resolved Hide resolved build-support/bin/check_header.py Outdated

Eric-Arellano added some commits May 14, 2019

@Eric-Arellano Eric-Arellano requested a review from blorente May 14, 2019

@blorente
Copy link
Contributor

left a comment

This looks amazing, thank you for the changes!

@Eric-Arellano Eric-Arellano merged commit fd26b98 into pantsbuild:master May 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:py3-header branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.