Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use curl --fail #7717

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented May 14, 2019

Otherwise we silently download bad files, and maybe try to run them later

@illicitonion illicitonion requested a review from Eric-Arellano May 14, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

It looks like you might have already done this, but please run these files through shellcheck. Until shellcheck.py lands, you can do this via the command $ shellcheck --shell=bash build-support/bin/check_shell.sh ....

No need to fix prior issues, as I have already done that in some PRs I have queued up. This is solely to ensure you aren't introducing new issuues.

Always use curl --fail
Otherwise we silently download bad files, and maybe try to run them later

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/curlfail branch from 7d4303f to 82ced8d May 14, 2019

@illicitonion illicitonion merged commit 4e9a77b into pantsbuild:master May 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/curlfail branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.