Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix hermetic environment issues with V2 tasks #7721
Specific test failures
Several of the
Way to specify environment variables
The naive solution to these problems would simply grab the local environment variables for
So, we must have some way to hardcode these environment variables via options, while providing sensible defaults that just work in the average case.
The greater design question is tracked by #7735.
Introduce a new idiom of using a
For example, to fix the encoding problem, we need to surface both
This does not close out #7735, as this design is not yet general enough for what we will likely need for future cases. Instead, we try to solve this problem with the minimum diff possible, while getting us closer to the final design.
May 14, 2019
referenced this pull request
May 15, 2019
cosmicexplorer left a comment
This is a great solution, seemingly with lots of work underneath it! I would love to at least have an idea of how we would handle generalizing the solutions here (such as setting
@cosmicexplorer ah oops, sorry I didn't mark this as WIP!
Daniel, Stu, and I this morning talked about how we likely want to convert this into a
Nevertheless, great comments on the
changed the title
WIP: Fix hermetic environment issues with V2 pytest runner
May 20, 2019
Solution has changed substantially.
illicitonion left a comment
Introducing a single flag for each env var here, when we're immediately going to completely re-work it to have a per-platform flag, seems a little weird, but makes sense as a stepping stone :)
Eric-Arellano left a comment
Agreed - this PR is very much focused on unblocking remoting work and not making the final design. Hopefully it helps get us closer to that final design at least.