Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Pipe LineOriented through the Console #7723

Conversation

Projects
None yet
4 participants
@blorente
Copy link
Contributor

commented May 14, 2019

Problem

LineOriented is a nice utility to mix options with the console, but unfortunately it writes directly to std{out,err} after grabbing them from the Console. Ideally, we would like all output to go through the Console class, to make things like the UI easier to develop.

Solution

  • Enhance print_std{out,err} in Console to accept a separator.
  • Refactor LineOriented a bit to only write to raw files when we are not writing to stdout.

Result

There should be no visible change in behavior.

@Eric-Arellano
Copy link
Contributor

left a comment

Good improvements all around. Thanks Borja!

@stuhood
Copy link
Member

left a comment

Whoopsie. Thanks!

@blorente blorente merged commit 4475fec into pantsbuild:master May 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.